Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(conditions): add search by input #150

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Conversation

Shxuuer
Copy link
Contributor

@Shxuuer Shxuuer commented Apr 2, 2024

No description provided.

Copy link

github-actions bot commented Apr 2, 2024

Copy link
Member

@lin594 lin594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有两个搜索按钮并不好,按照目前的设计我觉得可以只保留下面的那个搜索按钮

image

Comment on lines 453 to 455
if (!find) {
this.$message.error('未找到对应韵母!韵母是必选项!')
return
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥韵母是必选项

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果是因为双向转化里需要一个韵母的位置可以考虑用?还是什么代替一下?

Comment on lines 68 to 76
<a-row style="margin-top: 5px">
<a-input-search
v-model="searchContent"
enter-button
placeholder="请输入拼音"
size="large"
@search="search(searchContent)"
/>
</a-row>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我理解为,这个输入框的目的是和上面的选择框双向转换?
那我认为说,其实上面的单选框如果点点点发生变化了,这个地方应该会同步?

@lin594
Copy link
Member

lin594 commented Apr 2, 2024

另外,#146说的其实不是这个地方添加,我更新了一下描述。不过这个功能还是可以修改而后更新的

@Shxuuer
Copy link
Contributor Author

Shxuuer commented Apr 15, 2024

修改需求

Copy link

Copy link
Member

@lin594 lin594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个先通过了,不过搜索框里搜索的时候应该不需要额外添加“pinyin”吧?直接搜索就行

@lin594 lin594 merged commit 357bee7 into e-dialect:master Apr 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants