Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unnecessary print statements #371

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

py-thok
Copy link
Contributor

@py-thok py-thok commented Oct 28, 2024

close #367
删除了大部分不必要的print输出,保留了ipa以及部分测试的print输出。

@lin594
Copy link
Member

lin594 commented Oct 28, 2024

虽然我不知道你为啥突然开始翻阅这个)
但其实这里面可以有一些其他的工作
比如说重构 (原本的try catch 架构其实太长了,以及现在有全局的异常捕捉,所以业务逻辑可以重写

另外,我们用的是 AngularJS 那个风格的 commit message

@lin594 lin594 changed the title Remove unnecessary print statements refactor: remove unnecessary print statements Oct 28, 2024
Comment on lines 808 to 809
except Exception as e:
return JsonResponse({"msg": str(e)}, status=500)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这种整个函数都是try catch 的 其实现在都可以去掉了x

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

主要是泡泡说让我清一下issue 所以就清了一下(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

噢 忘记加type了

@lin594 lin594 merged commit 5027c31 into e-dialect:develop Oct 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

去除代码中多余的print()函数
2 participants