Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(word): creag tags filed #362

Merged
merged 10 commits into from
Apr 15, 2024
Merged

feat(word): creag tags filed #362

merged 10 commits into from
Apr 15, 2024

Conversation

CapooL
Copy link
Collaborator

@CapooL CapooL commented Mar 28, 2024

close #348

Copy link
Member

@lin594 lin594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

增删改查
删没影响
查已经有修改
增和改里面,对tag的处理似乎没有到位?

@@ -13,4 +13,5 @@
path("/upload_standard", upload_standard), # WD0302POST
path("/phonetic_ordering", csrf_exempt(PhoneticOrdering.as_view())), # WD0501
path("/dictionary", csrf_exempt(DictionarySearch.as_view())), # WD0502
path("/search", csrf_exempt(searchWordsByTags)),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我以为直接用原本那个 /words 然后加一个选项就vans了?

Comment on lines 470 to 471
except Exception as e:
return JsonResponse({"msg": str(e)}, status=500)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不要写这种形式的try except,有中间件自动捕获这些异常

Copy link
Member

@lin594 lin594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

等一下,application里也应该同步增加tags吧?

@CapooL
Copy link
Collaborator Author

CapooL commented Mar 28, 2024

等一下,application里也应该同步增加tags吧?

我看一下)

@lin594 lin594 changed the title feat(word): creag tags Filed feat(word): creag tags filed Apr 15, 2024
@lin594 lin594 merged commit ae322e1 into e-dialect:develop Apr 15, 2024
3 checks passed
@CapooL CapooL deleted the tags branch May 20, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

词语-标签字段
2 participants