feat: add sol signature support #18
Open
+4,184
−4,371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Total -- 473.07kb -> 315.28kb (33.35%) /docs/images/xcode-components.png -- 228.37kb -> 129.15kb (43.45%) /docs/images/open-xcode-settings.png -- 243.27kb -> 184.76kb (24.05%) /assets/favicon.png -- 1.43kb -> 1.38kb (3.82%) Signed-off-by: ImgBotApp <[email protected]> Co-authored-by: ImgBotApp <[email protected]>
andreaswierm
reviewed
Apr 9, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Solana signature functionality alongside existing extensions.
- Extended the client initialization to include the SolanaExtension.
- Added Solana message signing support in the DisplayAuthenticatedUserView along with updates to the UI.
- Updated test mocks and app configurations to integrate the Solana extension.
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/client.ts | Added import and extension chaining for SolanaExtension. |
| src/LoginView/LoginView.tsx | Removed unused background style and updated container style. |
| src/DisplayAuthenticatedUserView/DisplayAuthenticatedUserView.tsx | Added EVM and Solana message signing functions and adjusted wallet UI. |
| jest-setup.ts | Added and updated mocks to include solana-extension. |
| tests/client.spec.ts | Updated tests to check for the new solana extension. |
| App.tsx | Configured Buffer and TextEncoder for React Native support. |
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (1)
src/DisplayAuthenticatedUserView/DisplayAuthenticatedUserView.tsx:50
- [nitpick] Consider defining constants or enums for wallet chain values (e.g., 'EVM', 'SOL') instead of using hard-coded string literals to reduce potential errors and improve maintainability.
<Text>Wallet address: {wallet.address}</Text>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Solana signature support
additional minor changes: