Conversation
added 20 commits
February 25, 2026 10:33
… dependency - Remove `base profile: lightning` — no longer a sub-profile - Add all needed modules directly to .info.yml install list - Remove D9-only modules (ckeditor, quickedit, rdf, hal, color) - Replace `dxpr/lightning: 5.2.x-dev` with direct module dependencies - Remove ckeditor/fakeobjects (CKE4 plugin, D10 uses CKE5) - Remove core patch 1650930 (READ COMMITTED, resolved in D10) - Bump for D10.6: bootstrap5 ^3.0, webform ^6.2, ctools ^3.12 - Port install tasks from lightning.profile (front page, shortcuts) - Port user.role.administrator.yml and user.settings.yml config - Fix D10 deprecations (drupal_get_path → extension.list, accessCheck) This eliminates the need for the subprofile support core patch and removes the dxpr/lightning and dxpr/lightning_media repo dependencies.
- lightning_core ^6: Required by lightning_media 5.0.0-alpha2+ (the only version compatible with D10, as alpha1 needs views_infinite_scroll ^1.6 which is D9 only) - lightning_workflow ^4: Required to be compatible with lightning_core ^6 (workflow 3.x requires lightning_core ^5) - Both 6.x and 4.x versions drop hard contrib dependencies but still ship their submodules (lightning_page, lightning_roles, lightning_scheduler)
…m install These modules require media_entity_instagram and media_entity_twitter respectively, which are not included as dependencies. They are also not used in the D11 DXPR CMS setup.
- slideshow requires slick_entityreference (not in dependencies) - bulk_upload requires dropzonejs (not in dependencies) Both can be enabled later if needed with their dependencies.
- Replace editor.editor.full_html.yml with CKEditor 5 version from D10.6 core - Add ckeditor5 to install modules list - Remove obsolete ckeditor_media_browser and dropzone permissions from dxpr_builder role
…ng_media ^5.1 The DXPR fork only changed the vendor name. Upstream 5.1.x has D10 compatibility fixes (removed CKEditor 4 dependency, updated for lightning_core ^6). Less code to maintain.
Bootstrap 3 theme requires jquery_ui, jquery_ui_draggable, and jquery_ui_resizable which were removed from D10 core but available as contrib modules.
- Remove bootstrap (BS3) and bootstrap4 themes from install list - Remove jquery_ui modules (only needed for BS3) - Remove bootstrap/bootstrap4 composer deps - Keep bootstrap5, claro, and dxpr_theme
Must be enabled before theme installation since dxpr_theme 6.x depends on it as a module dependency.
- Set core_version_requirement to ^10.6 for all demo and example modules - Remove color.theme.dxpr config (color module removed in D10) - Remove gin theme requirement from dxpr_qa_demo
- Delete bootstrap4-dependent block config files - Delete bootstrap4.settings config - Remove bootstrap4 config overrides from install hook - Fix deprecated drupal_get_path() call
The node_type condition plugin was renamed to entity_bundle:node in D10.
lightning_scheduler's Time service override creates a circular dependency (cache.backend.database -> TimeInterface -> state -> cache.bootstrap) that is incompatible with Drupal 10.
Add drupal/bootstrap and its jQuery UI dependencies (jquery_ui, jquery_ui_draggable, jquery_ui_resizable) alongside bootstrap5 so the profile works with both dxpr_theme 1.x (BS3) and 6.x (BS5).
The color module was removed from D10 core but is available as contrib. dxpr_theme 1.x (BS3) needs it, so add the dependency and restore the color.theme.dxpr config files that were previously deleted.
dxpr_builder now requires the ai module, so the profile must ensure it is available at install time.
Without cdn_provider explicitly set to '', dxpr_theme defaults to null which fails the strict equality check and prevents local Bootstrap 3 JS from being loaded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
base profile: lightningdependency and the subprofile patch requirement (patch 3266057-149 doesn't apply to D10.6)dxpr/lightningare now direct dependencies incomposer.jsonlightning.profileported intolightning_dxpr.profileuser.role.administrator.ymlanduser.settings.ymlcopied from lightning since they're no longer inheritedcore_version_requirementto^10.6, removed CKEditor 4 references, updated module version constraintsBreaking changes
dxpr/lightningprofile — this is now a standalone profileTest plan
composer installin lightning_dxpr_project with this branch