Fix hover style for Colored Background and Colored Text modes#790
Open
Fix hover style for Colored Background and Colored Text modes#790
Conversation
…odes Remove fallback values (transparent/inherit) from base hover CSS var() calls so that when the variables are unset, the declarations become invalid at computed-value time and the mode-specific fallbacks (--dxt-color-base) take over correctly. Fixes: #785
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
transparentandinheritfallback values from base hovervar()calls indxpr-theme-navigation-colors.scss--dxt-setting-menu-hover-background,--dxt-setting-menu-hover-text-color,--dxt-setting-dropdown-hover-background,--dxt-setting-dropdown-hover-text-color) are not set by the user, the declarations now become invalid at computed-value time (IACVT), allowing the mode-specific selectors (hover-background, hover-text, hover-opacity) to apply their correct fallbacks (e.g.,var(--dxt-color-base))Test plan
Fixes: #785