Fix button text color overridden by region link color rules#766
Open
Fix button text color overridden by region link color rules#766
Conversation
79f2208 to
41f78e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issues
Summary
Region-level
a { color: ... }CSS rules override Bootstrap button text colors when buttons use<a>elements. This is the same bug class fixed in PR #726 for cards.Problem
Bare
aselectors in region SCSS set link colors that bleed into<a class="btn ...">elements:.dxpr-theme-header a { color: headertext }— overrides btn-primary/btn-secondary text color.dxpr-theme-main-menu a { color: headertext }— same issue in main menu#secondary-header a { color: secheadertext }— affects buttons in secondary header.dxpr-theme-footer a { color: footertext }— affects buttons in footer.region-sidebar-first/second a { color: text }— affects sidebar buttons.content .list-inline a { color: text }— affects inline list buttonsSolution
Apply
a:not(.btn)exclusion to all affected selectors, matching the pattern from PR #726.Files Changed
scss/components/dxpr-theme-header.scss— 2 selectors updated (lines 32, 72)scss/components/dxpr-theme-secondary-header.scss— 1 selector updated (line 12)scss/base/layout.scss— 1 selector updated (footer, line 259)scss/base/typography.scss— 2 selectors updated (lines 109, 215)Checklist