Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality Update #2033

Open
wants to merge 123 commits into
base: master
Choose a base branch
from
Open

Code Quality Update #2033

wants to merge 123 commits into from

Conversation

Mil4n0r
Copy link
Collaborator

@Mil4n0r Mil4n0r commented Jul 8, 2024

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
We want to follow the best practices and achieve a higher code quality by using automatic tools (Husky, Prettier, ESLint and Staged-Lint). This PR contains both the setup of the tools and the fix of most existing code quality issues.

The goal to achieve is to remove all the custom rules existing in the eslint configuration file and pass with no errors and no warnings.

Closes #2031, #2043

@Mil4n0r Mil4n0r marked this pull request as ready for review July 9, 2024 12:48
@Mil4n0r Mil4n0r marked this pull request as draft August 6, 2024 12:10
@Mil4n0r Mil4n0r marked this pull request as ready for review August 8, 2024 11:59
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prettier part will be uncommented on a separate PR to prevent increasing the review size (even further)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant