Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forms #34

Merged
merged 8 commits into from
Jun 3, 2017
Merged

Forms #34

merged 8 commits into from
Jun 3, 2017

Conversation

katbow
Copy link
Collaborator

@katbow katbow commented Jun 2, 2017 •
edited
Loading

Add remaining sections to forms #16

  • Focus state
  • Disabled state
  • Readonly state
  • Help text
  • Validation states
  • Control sizing

@katbow katbow self-assigned this Jun 2, 2017
@katbow katbow requested a review from nelsonic June 2, 2017 12:16
@katbow katbow assigned nelsonic and unassigned katbow Jun 2, 2017
nelsonic
nelsonic approved these changes Jun 3, 2017
View reviewed changes
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katbow forms look great! 🎉

@nelsonic nelsonic merged commit 8c9b228 into master Jun 3, 2017
@nelsonic nelsonic deleted the forms branch June 3, 2017 13:16
@katbow katbow mentioned this pull request Jun 3, 2017
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonic nelsonic nelsonic approved these changes

Assignees

@nelsonic nelsonic

Labels
in-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katbow @nelsonic