execution-core: added serde support for MoonlightTransactionEvent #3046
+256
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-sonuga
force-pushed
the
add-serde-feature-execution-core
branch
from
8b9d6ae to
458f951
Compare
d-sonuga
force-pushed
the
add-serde-feature-execution-core
branch
from
458f951 to
9114601
Compare
Neotamandua
reviewed
Nov 25, 2024
execution-core/Cargo.toml
Outdated
| @@ -57,3 +62,5 @@ groth16 = [ | |||
|
|
|||
| # Enables std feature for dusk-plonk | |||
| std = ["dusk-plonk/std"] | |||
|
|
|||
| serde_support = ["serde", "bs58", "serde_json"] | |||
There was a problem hiding this comment.
Suggested change
| serde_support = ["serde", "bs58", "serde_json"] | |
| serde = ["serde", "bs58", "serde_json"] |
Many crates expose serde support on their own crates through a feature flag named the same as the crate, so I would prefer to rename this to just "serde" as a flag
execution-core/src/transfer.rs
Outdated
Comment on lines
529
to
530
| serde(with = "serde_support::bs58_serde") | ||
| )] | ||
| pub memo: Vec<u8>, |
There was a problem hiding this comment.
Memos should not be bs58 encoded. Prefer using hex for bytes and bs58 encoding only for the bytes of address types like AccountPublicKey
Neotamandua
reviewed
Nov 25, 2024
execution-core/src/transfer.rs
Outdated
| pub refund_info: Option<(AccountPublicKey, u64)>, | ||
| } | ||
|
|
||
| #[cfg(feature = "serde_support")] | ||
| mod serde_support { |
There was a problem hiding this comment.
It probably makes sense to have this as a separate file. Then you can also import the modules in it that are likely to be reused (e.g., bs58_serde) on other structs located in other files.
d-sonuga
force-pushed
the
add-serde-feature-execution-core
branch
2 times, most recently
from
5e58188 to
e329820
Compare
d-sonuga
force-pushed
the
add-serde-feature-execution-core
branch
from
e329820 to
645e9bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to add the feature described in #2773.
I've only added serde support for a single event struct -
MoonlightTransactionEvent.I need some thoughts on whether what I have now is okay.