Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rusk-wallet: Allow withdrawing of partial rewards #3041

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Daksh14
Copy link
Contributor

@Daksh14 Daksh14 commented Nov 22, 2024

Pass reward param to withdraw transaction function Add check for withdraw amount

Closes #2538

@Daksh14 Daksh14 requested review from welf, HDauven and moCello November 22, 2024 00:41
@Daksh14 Daksh14 force-pushed the withdraw_partial_rewards branch from 29acc9d to 407c04e Compare November 22, 2024 00:42
Copy link
Member

@moCello moCello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, the biggest one being that I would have the stake-reward be an optional value. So that when the user doesn't specify anything, the entire reward is withdrawn.

welf
welf previously approved these changes Dec 2, 2024
@Daksh14 Daksh14 force-pushed the withdraw_partial_rewards branch 2 times, most recently from 42b32d6 to d7770d7 Compare December 28, 2024 23:30
@Daksh14 Daksh14 force-pushed the withdraw_partial_rewards branch 5 times, most recently from fe7c1ed to a3b0e76 Compare January 20, 2025 19:10
@Daksh14 Daksh14 requested a review from herr-seppia January 21, 2025 23:17
@Daksh14 Daksh14 force-pushed the withdraw_partial_rewards branch 2 times, most recently from 754f4f0 to bc85e70 Compare January 31, 2025 18:16
Pass reward param to withdraw transaction function
Add check for withdraw amount
Rename helper method to be more correct
@Daksh14 Daksh14 force-pushed the withdraw_partial_rewards branch from bc85e70 to c9d8634 Compare February 10, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rusk-wallet: Allow users to withdraw specific value from staking reward
5 participants