rusk-wallet: Clear up status messages #2728
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herr-seppia
requested changes
Oct 22, 2024
There was a problem hiding this comment.
2 request
- I believe we should keep those infos when running in non-interactive (This is actually removing any log when run in non-interactive)
- Those updates were useful in case of error to know where the flow stopped. Can you consider to introduce a context in the error management?
moCello
force-pushed
the
mocello/cleanup_sync_status
branch
from
1cb0e2d to
ad98427
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean-up some of the clients status messages.
There are still status updates for the high-level syncing, proving and tx-propagation.
All lower-level status updates have been removed.
This fixes the overlap of status and wallet prints when the shielded address is not done syncing yet:
Shielded address - 2b7MttFRHDMfwKP1uqY8Ni4tjfdMX9dmam3qh5892MzJpFAyhHaUeuueaZhy95YaXa9okMwirPqFRpwtfGxBfKQwu Syncing...e count received!