dusk-merkle: add bounds check at Tree::insert
#92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ureeves
force-pushed
the
insert-bounds-check
branch
from
9394897 to
b6ca0f4
Compare
A panic on an out of bounds insertion is expected in the merkle tree, however, the panic message is a bit cryptic. This commit adds a bounds check (`index < capacity`) and improves the error message such that it is clear to whomever calls it. Resolves: #91
ureeves
force-pushed
the
insert-bounds-check
branch
from
b6ca0f4 to
e422e58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A panic on an out of bounds insertion is expected in the merkle tree, however, the panic message is a bit cryptic. This commit adds a bounds check (
index < capacity) and improves the error message such that it is clear to whomever calls it.Resolves: #91