Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure the code for easier apps integration #121

Merged
merged 10 commits into from
Nov 28, 2024
Merged

Restructure the code for easier apps integration #121

merged 10 commits into from
Nov 28, 2024

Conversation

xevisalle
Copy link
Member

@xevisalle xevisalle commented Nov 18, 2024 •
edited
Loading

This PR tackles two points:

  • Restructure the Citadel protocol implementation (now in the /core folder)
  • Port the license contract to this repository (now in the /contract folder)

@xevisalle xevisalle linked an issue Nov 18, 2024 that may be closed by this pull request
Restructure the objects used in the code #98
Closed
@xevisalle xevisalle force-pushed the port_contracts branch 2 times, most recently from 5579a71 to e65eba7 Compare November 25, 2024 17:40
@xevisalle xevisalle linked an issue Nov 26, 2024 that may be closed by this pull request
Port License contract from Rusk #122
Closed
@xevisalle @miloszm
contract: Port contract from Rusk
87c4a56 
Co-authored-by: Milosz Muszynski <[email protected]>
@xevisalle xevisalle force-pushed the port_contracts branch 2 times, most recently from 71d52de to f87c84f Compare November 26, 2024 03:25
@xevisalle xevisalle self-assigned this Nov 26, 2024
@xevisalle xevisalle marked this pull request as ready for review November 26, 2024 03:54
@xevisalle xevisalle requested review from miloszm and HDauven November 26, 2024 09:49
miloszm
miloszm requested changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@miloszm miloszm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good to me - one remark - could contract's git dependencies for rusk-abi and execution-core be converted to regular version dependencies? Also, cargo t does not compile for me, which I think is related to the said dependencies.

miloszm
miloszm approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@miloszm miloszm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xevisalle
Copy link
Member Author

Looks really good to me - one remark - could contract's git dependencies for rusk-abi and execution-core be converted to regular version dependencies? Also, cargo t does not compile for me, which I think is related to the said dependencies.

execution_core is not released yet, and the current released rusk_abi version is kinda old. I'd say is better for now to stick with the git

@xevisalle xevisalle merged commit 90bc004 into main Nov 28, 2024
6 checks passed
@xevisalle xevisalle deleted the port_contracts branch November 28, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miloszm miloszm miloszm approved these changes

@HDauven HDauven Awaiting requested review from HDauven

Assignees

@xevisalle xevisalle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port License contract from Rusk Restructure the objects used in the code
2 participants
@xevisalle @miloszm