Add Libcxx Compatability Mode to AnyBlob #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, AnyBlob can only link against the gnu standard library. This commit adds a new CMake option `ANYBLOB_LIBCXX_COMPAT` that allows building AnyBlob and linking against libcxx. The main changes in this commit are: - Missing header includes. We don't bring in the same transitive headers when including the libcxx headers, as a result some string headers were missing in some places. - Remove `ThroughputResolver` when building with libcxx. This is the more invasive of the two changes. The `ThroughputResolver` depends on `__gnu_pbds::tree`, which is not spported in libcxx. When building in libcxx compatibility mode, we now remove this resolve completely. In this case, the `io_uring_socket.cpp` falls back onto the default resolver. We have verified that we can build all targets in libcxx compatibility mode. We have verified that both unit and integration tests pass when building with `clang-15` and the libcxx compatibility mode.
This commit adds the clang toolchain to the CI. We turn the main jobs into a test matrix that either runs with the clang, or gcc toolchain. When using the gcc toolchain everything stays as-is. When using the clang toolchain we use clang/clang++ as C/C++ compilers, respectively. We also build `AnyBlob` using `-DANYBLOB_LIBCXX_COMPAT=1`, which ensures that `libcxx` is used as a standard library. In principle, the test matrix could be even bigger: we could build with libcxx and gcc, and gnu c++ and clang. But we don't tests this for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3