Merge pull request #23 from duongminhhieu/develop

refactor: validation + throw exception
duongminhhieu · Jun 8, 2024 · 5e68ac4 · 5e68ac4
2 parents a09a1af + e4e708a
commit 5e68ac4
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/src/main/java/com/learning/yasminishop/common/configs/security/SecurityConfiguration.java b/src/main/java/com/learning/yasminishop/common/configs/security/SecurityConfiguration.java
@@ -29,7 +29,7 @@ public class SecurityConfiguration {
             "/swagger-ui/**",
             "/api-docs/**",
             "/categories",
-            "/categories/{slug}",
+            "/categories/slug/{slug}",
             "/products",
             "/products/{slug}",
             "/rating",

diff --git a/src/main/java/com/learning/yasminishop/product/dto/request/ProductRequest.java b/src/main/java/com/learning/yasminishop/product/dto/request/ProductRequest.java
@@ -2,6 +2,7 @@
 
 import com.learning.yasminishop.common.validator.FieldNotEmpty.FieldNotEmptyConstraint;
 import com.learning.yasminishop.common.validator.FieldNotNull.FieldNotNullConstraint;
+import jakarta.validation.constraints.Min;
 import lombok.*;
 import lombok.experimental.FieldDefaults;
 
@@ -40,6 +41,7 @@ public class ProductRequest {
 
     @FieldNotNullConstraint(field = "quantity", message = "FIELD_NOT_NULL")
     @FieldNotEmptyConstraint(field = "quantity", message = "FIELD_NOT_EMPTY")
+    @Min(value = 1, message = "INVALID_QUANTITY")
     Long quantity;
 
     @FieldNotNullConstraint(field = "isAvailable", message = "FIELD_NOT_NULL")

diff --git a/src/main/java/com/learning/yasminishop/yasminiai/YasMiniAIService.java b/src/main/java/com/learning/yasminishop/yasminiai/YasMiniAIService.java
@@ -91,7 +91,7 @@ public List<ProductResponse> findCarByImage(MultipartFile file){
 
         } catch (Exception e) {
             log.error("Error finding car by image", e);
-            throw new AppException(ErrorCode.GENERATIVE_AI_ERROR);
+            return List.of();
         }
     }
 

diff --git a/src/main/resources/application.yml b/src/main/resources/application.yml
@@ -14,6 +14,7 @@ server:
   port: 8080
   servlet:
     context-path: /api/v1
+  # address: 0.0.0.0
 
 application:
   jwt: