Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use properties instead of private fields in dunstify #1444

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

bynect
Copy link
Member

@bynect bynect commented Feb 24, 2025

not tested properly but should work

@holytrousers
Copy link

hi @bynect ,
-r id started crashing with segmentation fault, now when compiling git version (using aur) it gives me this error that looks related to this commit :

dunstify.c: In function ‘get_id’:
dunstify.c:207:21: error: ‘NotifyNotification’ has no member named ‘priv’
  207 |     knickers *kn = n->priv;
      |                     ^~
dunstify.c: In function ‘put_id’:
dunstify.c:215:21: error: ‘NotifyNotification’ has no member named ‘priv’
  215 |     knickers *kn = n->priv;
      |                     ^~

@bynect
Copy link
Member Author

bynect commented Feb 25, 2025

hi @bynect ,
-r id started crashing with segmentation fault, now when compiling git version (using aur) it gives me this error that looks related to this commit :

dunstify.c: In function ‘get_id’:
dunstify.c:207:21: error: ‘NotifyNotification’ has no member named ‘priv’
  207 |     knickers *kn = n->priv;
      |                     ^~
dunstify.c: In function ‘put_id’:
dunstify.c:215:21: error: ‘NotifyNotification’ has no member named ‘priv’
  215 |     knickers *kn = n->priv;
      |                     ^~

Yes see #1443

@bynect bynect merged commit 73c7f92 into dunst-project:master Feb 25, 2025
23 checks passed
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.32%. Comparing base (fe7f928) to head (2099296).
Report is 3 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1444   +/-   ##
=======================================
  Coverage   65.32%   65.32%           
=======================================
  Files          50       50           
  Lines        8763     8763           
  Branches     1034     1034           
=======================================
  Hits         5724     5724           
  Misses       3039     3039           
Flag Coverage Δ
unittests 65.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deftclaw
Copy link

Pulled v1.12.1, wouldn't build, switched to master. Built and -r function is working again, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants