-
Notifications
You must be signed in to change notification settings - Fork 2
Add support for snowflake #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add support for snowflake #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment @cursor review
or bugbot run
to trigger another review on this PR
image built and pushed locally already as: |
@a-monteiro can I get a review and an official release of this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems ok, I assume you've tested using this snowflake driver.
Let me know whever you merge it and I'll build an image for you
/sql_exporter.yml | ||
test_configs/ | ||
.idea/* | ||
keys/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we need any of these, specially since we're not adding anything bigquery related
Note
Adds Snowflake and BigQuery SQL drivers and updates dependencies (incl. AWS SDK) and codegen to support them.
github.com/snowflakedb/gosnowflake
andgithub.com/solcates/go-sql-bigquery
viadrivers.go
and add todrivers_gen.go
custom
list.github.com/dave/jennifer/jen
and use it indrivers_gen.go
for generatingdrivers.go
.[email protected]
,[email protected]
.github.com/aws/aws-sdk-go-v2
tov1.38.1
and update related AWS packages.go.mod
/go.sum
.Written by Cursor Bugbot for commit 331a703. This will update automatically on new commits. Configure here.