add bn128 encode & fix inputs name #381
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wiasliaw is attempting to deploy a commit to the Duneanalytics Team on Vercel. A member of the Team first needs to authorize it. |
2xic
reviewed
Oct 14, 2025
Collaborator
2xic
left a comment
2xic
left a comment
There was a problem hiding this comment.
thank you! Just a minor comment
|
|
||
| In the group $G_1$, points on the base field $F_p$ consist of (x, y) coordinates, where each coordinate is encoded as 32 bytes. | ||
|
|
||
| In the group $G_2$, points on the extension field $F_{p^2}$ are represented with coordinates (x, y) where `x = c0 + c1 * i` and `y = c0 + c1 * i`, with each component (x_c1, x_c0, y_c1, c_c0) encoded as 32 bytes. |
Collaborator
There was a problem hiding this comment.
I'm not an expert on this precompile or the annotation, but I think there are two typos:
- (x_c1, x_c0, y_c1, c_c0) should be (x_c1, x_c0, y_c1, y_c0)
2.x = c0 + c1 * iandy = c0 + c1 * ishould bex = x_c0 + x_c1 * iandy = y_c0 + y_c1 * i
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #324.