Fix/missing description and broken md layout #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tienshaoku is attempting to deploy a commit to the Duneanalytics Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
@2xic @TheEdgeOfRage |
Collaborator
|
Hey @tienshaoku, this looks good, will test it and review early next week. |
2xic
reviewed
Oct 14, 2025
| 'flex-1 lg:pr-8': referenceItem.dynamicFee, | ||
| })} | ||
| > | ||
| {referenceItem.description && ( |
Collaborator
There was a problem hiding this comment.
Sorry for super late review. The only thing I find a bit odd is seeing this on the desktop version 🤔
Should we only show it on mobile?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr includes two fixes:
50f89af
Issue
Descriptions are missing in the expanded view, which is not a problem on larger screens but confusing on mobile view. For example, for
RETURNDATACOPY, without the description it's very confusing (for opcode learners like me) what this Opcode does.Fix
Added description sections to all expanded section, no matter mobile view or not.
I reused descriptions directly
referenceItemsince descriptions aren't part of md files.18ee26f
Issue
For screen width >= 768 && < 1024, the column layout is squeezed together.
Fix
Change breakpoints of
Input&Outputfromlgtomds.t. there's not unintended gap when it'smdview.width == 768: columns are rather tight but maybe acceptable?width == 1023If further improvements should be made to the commits, please lmk and I'm v happy to help since this website serves me (and i believe many) tremendous help for learning about EVM, bytecode and Huff!
Btw the reason why I use mobile view is that I keep the browser on the left and code editor on the right s.t. I can easily write Huff code based on the info on the left, which made me to want to help fix this issue to improve mobile/ smaller screen view users' experience :)