Skip to content

fix: ignore dots inside brackets when extracting basename #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 15, 2025
Merged

fix: ignore dots inside brackets when extracting basename #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
46dd38b
test: add Next.js dynamic routes support for filename-naming-conventi…
eastdraconis Oct 5, 2025
7c83ccf
fix: ignore dots inside brackets when extracting basename
eastdraconis Oct 5, 2025
5f2bdf3
test: add tests for POSIX and Windows
eastdraconis Oct 14, 2025
a1582b1
refactor: remove redundant guard in getBasename
eastdraconis Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 23 additions & 5 deletions lib/utils/filename.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,29 @@ export const getFolderPath = (p) => posix.join(posix.dirname(p), posix.sep);
* @param {string} filename filename without path
* @param {boolean} [ignoreMiddleExtensions] flag to ignore middle extensions
*/
export const getBasename = (filename, ignoreMiddleExtensions = false) =>
filename.substring(
0,
ignoreMiddleExtensions ? filename.indexOf('.') : filename.lastIndexOf('.')
);
export const getBasename = (filename, ignoreMiddleExtensions = false) => {
const findDotsOutsideBrackets = (str) => {
const positions = [];
let depth = 0;

for (let i = 0; i < str.length; i++) {
if (str[i] === '[') depth++;
else if (str[i] === ']') depth--;
else if (str[i] === '.' && depth === 0) {
positions.push(i);
}
}
return positions;
};

const dotPositions = findDotsOutsideBrackets(filename);

const curPosition = ignoreMiddleExtensions
? dotPositions[0]
: dotPositions[dotPositions.length - 1];

return filename.substring(0, curPosition);
};

/**
* @returns {string[]} all folders
Expand Down
76 changes: 76 additions & 0 deletions tests/lib/rules/filename-naming-convention.posix.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,6 +804,82 @@ ruleTester.run(
}
);

ruleTester.run(
"filename-naming-convention with Next.js dynamic routes and option: [{ '**/*.{js,jsx,ts,tsx}': 'NEXT_JS_PAGE_ROUTER_FILENAME_CASE' }, { ignoreMiddleExtensions: true }]",
rule,
{
valid: [
{
code: "var foo = 'bar';",
filename: 'src/pages/blog/[[...userId]].tsx',
options: [
{ '**/*.{js,jsx,ts,tsx}': 'NEXT_JS_PAGE_ROUTER_FILENAME_CASE' },
{ ignoreMiddleExtensions: true },
],
},
{
code: "var foo = 'bar';",
filename: 'src/pages/blog/[[...slug]].tsx',
options: [
{ '**/*.{js,jsx,ts,tsx}': 'NEXT_JS_PAGE_ROUTER_FILENAME_CASE' },
{ ignoreMiddleExtensions: true },
],
},
{
code: "var foo = 'bar';",
filename: 'src/pages/blog/[...params].tsx',
options: [
{ '**/*.{js,jsx,ts,tsx}': 'NEXT_JS_PAGE_ROUTER_FILENAME_CASE' },
{ ignoreMiddleExtensions: true },
],
},
{
code: "var foo = 'bar';",
filename: 'src/pages/user/[id].tsx',
options: [
{ '**/*.{js,jsx,ts,tsx}': 'NEXT_JS_PAGE_ROUTER_FILENAME_CASE' },
{ ignoreMiddleExtensions: true },
],
},
{
code: "var foo = 'bar';",
filename: 'src/pages/post/[postId].test.tsx',
options: [
{ '**/*.{js,jsx,ts,tsx}': 'NEXT_JS_PAGE_ROUTER_FILENAME_CASE' },
{ ignoreMiddleExtensions: true },
],
},
{
code: "var foo = 'bar';",
filename: 'src/pages/api/user.test.ts',
options: [
{ '**/*.{js,jsx,ts,tsx}': 'NEXT_JS_PAGE_ROUTER_FILENAME_CASE' },
{ ignoreMiddleExtensions: true },
],
},
],

invalid: [
{
code: "var foo = 'bar';",
filename: 'src/pages/blog/Invalid_Name.tsx',
options: [
{ '**/*.{js,jsx,ts,tsx}': 'NEXT_JS_PAGE_ROUTER_FILENAME_CASE' },
{ ignoreMiddleExtensions: true },
],
errors: [
{
message:
'The filename "Invalid_Name.tsx" does not match the "NEXT_JS_PAGE_ROUTER_FILENAME_CASE" pattern',
column: 1,
line: 1,
},
],
},
],
}
);

ruleTester.run(
"filename-naming-convention with option: [{ '**/*.js': '__+([a-z])', '**/*.jsx': '__+([a-z])' }]",
rule,
Expand Down
76 changes: 76 additions & 0 deletions tests/lib/rules/filename-naming-convention.windows.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,6 +826,82 @@ ruleTester.run(
}
);

ruleTester.run(
"filename-naming-convention with Next.js dynamic routes and option on Windows: [{ '**/*.{js,jsx,ts,tsx}': 'NEXT_JS_PAGE_ROUTER_FILENAME_CASE' }, { ignoreMiddleExtensions: true }]",
rule,
{
valid: [
{
code: "var foo = 'bar';",
filename: 'src\\pages\\blog\\[[...userId]].tsx',
options: [
{ '**/*.{js,jsx,ts,tsx}': 'NEXT_JS_PAGE_ROUTER_FILENAME_CASE' },
{ ignoreMiddleExtensions: true },
],
},
{
code: "var foo = 'bar';",
filename: 'src\\pages\\blog\\[[...slug]].tsx',
options: [
{ '**/*.{js,jsx,ts,tsx}': 'NEXT_JS_PAGE_ROUTER_FILENAME_CASE' },
{ ignoreMiddleExtensions: true },
],
},
{
code: "var foo = 'bar';",
filename: 'src\\pages\\blog\\[...params].tsx',
options: [
{ '**/*.{js,jsx,ts,tsx}': 'NEXT_JS_PAGE_ROUTER_FILENAME_CASE' },
{ ignoreMiddleExtensions: true },
],
},
{
code: "var foo = 'bar';",
filename: 'src\\pages\\user\\[id].tsx',
options: [
{ '**/*.{js,jsx,ts,tsx}': 'NEXT_JS_PAGE_ROUTER_FILENAME_CASE' },
{ ignoreMiddleExtensions: true },
],
},
{
code: "var foo = 'bar';",
filename: 'src\\pages\\post\\[postId].test.tsx',
options: [
{ '**/*.{js,jsx,ts,tsx}': 'NEXT_JS_PAGE_ROUTER_FILENAME_CASE' },
{ ignoreMiddleExtensions: true },
],
},
{
code: "var foo = 'bar';",
filename: 'src\\pages\\api\\user.test.ts',
options: [
{ '**/*.{js,jsx,ts,tsx}': 'NEXT_JS_PAGE_ROUTER_FILENAME_CASE' },
{ ignoreMiddleExtensions: true },
],
},
],

invalid: [
{
code: "var foo = 'bar';",
filename: 'src\\pages\\blog\\Invalid_Name.tsx',
options: [
{ '**/*.{js,jsx,ts,tsx}': 'NEXT_JS_PAGE_ROUTER_FILENAME_CASE' },
{ ignoreMiddleExtensions: true },
],
errors: [
{
message:
'The filename "Invalid_Name.tsx" does not match the "NEXT_JS_PAGE_ROUTER_FILENAME_CASE" pattern',
column: 1,
line: 1,
},
],
},
],
}
);

ruleTester.run(
"filename-naming-convention with option on Windows: [{ '**/*.js': 'CAMEL_CASE' }, { ignoreMiddleExtensions: true }]",
rule,
Expand Down