Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow SDK to call stays accommodation endpoint #924

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Allow SDK to call stays accommodation endpoint #924

merged 3 commits into from
Jun 26, 2024

Conversation

jekku
Copy link
Contributor

@jekku jekku commented Jun 25, 2024

What's here?

  • This adds an accommodation property to the main Stays object.
  • It is initialised with the suggestions function
  • A new type, AccommodationSuggestions is introduced. This is an excerpt of the larger Accommodation object.

@jekku jekku requested a review from a team as a code owner June 25, 2024 12:23
@jekku jekku marked this pull request as draft June 25, 2024 12:23
@jekku jekku marked this pull request as ready for review June 25, 2024 12:32
igorp1
igorp1 approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@igorp1 igorp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you! Just left one comment

src/Stays/Accommodation/Accommodation.ts Outdated Show resolved Hide resolved
@jekku jekku force-pushed the jo-accommodation-suggestions branch from 29677f1 to 3ec0014 Compare June 26, 2024 08:34
@jekku jekku merged commit a10a659 into main Jun 26, 2024
4 checks passed
@jekku jekku deleted the jo-accommodation-suggestions branch June 26, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorp1 igorp1 igorp1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jekku @igorp1