Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accommodation based search in Duffel Javascript SDK #768

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

jekku
Copy link
Contributor

@jekku jekku commented Aug 15, 2023

What's here?

We have an upcoming release to search for accommodation.

This simply extends the types you can pass to Stays.search in the SDK to allow for accommodation based search.

This also makes sure that the SDK recognises the ID inside the accommodation as part of the main type.

Where can I read more?

An updated guide is coming out soon, but for the mean time, a preview for the new parameters is documented in our search documentation

@jekku jekku requested a review from a team as a code owner August 15, 2023 08:55
Copy link
Contributor

@ulissesalmeida ulissesalmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty cool 🎉

@ulissesalmeida
Copy link
Contributor

ulissesalmeida commented Aug 15, 2023

@jekku

I think you need to rename your commit to title to add the keyword "feat", so the auto release can properly patch the library version:

feat(stays): Add new accommodation parameter for Search

And then squash the fixes in a single feat commit.

@jekku jekku force-pushed the jo-accommodation-based-search branch from 40373b2 to 1024fac Compare August 15, 2023 10:23
@andrejak andrejak merged commit de1fc02 into main Aug 16, 2023
4 checks passed
@andrejak andrejak deleted the jo-accommodation-based-search branch August 16, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants