Make region configurable #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muodov
force-pushed
the
configurable-region
branch
from
f380402
to
d2906a1
Compare
kdzwinel
reviewed
Aug 30, 2024
| @@ -12,8 +12,7 @@ module.exports = function getListOfJSONPathsFromFolder(folderPath) { | |||
| return true; | |||
| } | |||
|
|
|||
| console.trace('Skipping path', resolvedPath, stat); | |||
| process.exit(1); | |||
There was a problem hiding this comment.
Why we had that here? And why was it removed? It looks like some unexpected state where we want to stop the whole process, no?
There was a problem hiding this comment.
I think it was a mistake. I added this in #24, which was not supposed to change any functionality. I think I did this for debugging, and just didn't notice it in the PR because the diff is not shown.
This should not happen again since the data PRs are automated now.
kdzwinel
reviewed
Aug 30, 2024
kdzwinel
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it easier to generate wiki for non-US regions