Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix psl parsing #52

Merged
merged 4 commits into from
Jul 29, 2024
Merged

fix psl parsing #52

merged 4 commits into from
Jul 29, 2024

Conversation

jdorweiler
Copy link
Collaborator

@jdorweiler jdorweiler commented Jul 26, 2024 •
edited
Loading

Added tests and fixed a bug with psl parsing where domains with a substring match to a psl a.site-com.example.com would match on com.example.com

Test:

  1. set `pslExtras' in your config file to point to a local version of https://github.com/duckduckgo/tracker-radar/blob/main/build-data/static/pslExtras.json
  2. mocha test/custom-psl-paring.test.js

@jdorweiler jdorweiler requested a review from dharb July 26, 2024 18:58
@jdorweiler jdorweiler removed the request for review from dharb July 26, 2024 19:07
@jdorweiler jdorweiler marked this pull request as draft July 26, 2024 19:07
@jdorweiler jdorweiler requested a review from dharb July 26, 2024 19:30
@jdorweiler jdorweiler marked this pull request as ready for review July 26, 2024 19:30
dharb
dharb requested changes Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@dharb dharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem good to me, but tests seem to be failing. Mind getting those to pass before we merge?

@jdorweiler jdorweiler requested a review from dharb July 29, 2024 14:25
dharb
dharb approved these changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@dharb dharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for getting the tests green.

@dharb dharb merged commit 7df2d3a into main Jul 29, 2024
2 checks passed
@dharb dharb deleted the jd/psl-fix branch July 29, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dharb dharb dharb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdorweiler @dharb