Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloads UI tests #3601

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Downloads UI tests #3601

merged 2 commits into from
Dec 4, 2024

Conversation

jotaemepereira
Copy link
Collaborator

@jotaemepereira jotaemepereira commented Nov 26, 2024

Task/Issue URL: https://app.asana.com/0/1204006570077678/1205717021705372/f
Tech Design URL:
CC:

Description:
Adds UI tests for downloads

Steps to test this PR:

  1. I’ve kicked a new UI build: https://github.com/duckduckgo/macos-browser/actions/runs/12037893924. It should be ✅

Definition of Done:

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@jotaemepereira jotaemepereira requested a review from ayoy November 26, 2024 20:50
Copy link
Contributor

github-actions bot commented Dec 4, 2024

This PR has been inactive for more than 7 days and will be automatically closed 7 days from now.

@github-actions github-actions bot added the stale label Dec 4, 2024
@ayoy ayoy removed the stale label Dec 4, 2024
Copy link
Collaborator

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jotaemepereira I'm terribly sorry for the delay 🙇 The tests loook great and work reliably on my local machine. The CI is green so Let's Get This Merged 😎

@jotaemepereira jotaemepereira merged commit a8b8789 into main Dec 4, 2024
20 checks passed
@jotaemepereira jotaemepereira deleted the juan/implement-downloads-tests branch December 4, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants