Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malware protection 2: API Client refactoring #3595

Open
wants to merge 2 commits into
base: alex/malware-protection-1
Choose a base branch
from

Conversation

mallexxx
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/481882893211075/1208033567421351/f
BSK PR: duckduckgo/BrowserServicesKit#1092

Description:

  • Refactor APIClient to use Networking.APIRequestV2; implement generic request/response (BSK)

Optional E2E tests:

  • Run PIR E2E tests
    Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.

Steps to test this PR:

  1. Validate Phishing Protection change sets and Match API calls work as before

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@mallexxx mallexxx changed the title Malware protection: API Client refactoring Malware protection 1: API Client refactoring Nov 27, 2024
@mallexxx mallexxx changed the title Malware protection 1: API Client refactoring Malware protection 2: API Client refactoring Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant