Adding pixels for tracking content blocking rules fetch/lookup #3589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
studiosutara
force-pushed
the
smodi/content_blocking_lookup_time_tracking
branch
3 times, most recently
from
3ecfc39 to
26c95a2
Compare
bwaresiak
reviewed
Nov 26, 2024
| case .contentBlockingNoMatchInLRC: | ||
| return "m_content_blocking_no_match_in_lrc" | ||
| case .contentBlockingLRCMissing: | ||
| return "m_content_blocking_lrc_missing" |
There was a problem hiding this comment.
We should not be prefixing these with 'm' on macOS, as it gets populated automatically.
studiosutara
force-pushed
the
smodi/content_blocking_lookup_time_tracking
branch
from
204bcce to
6a61961
Compare
studiosutara
force-pushed
the
smodi/content_blocking_lookup_time_tracking
branch
from
6a61961 to
2809a99
Compare
studiosutara
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Nov 27, 2024
<!-- Note: This checklist is a reminder of our shared engineering expectations. --> Please review the release process for BrowserServicesKit [here](https://app.asana.com/0/1200194497630846/1200837094583426). **Required**: Task/Issue URL: https://app.asana.com/0/1208613456171888/1208801514911204/f iOS PR: duckduckgo/iOS#3597 macOS PR: duckduckgo/macos-browser#3589 What kind of version bump will this require?: Major **Optional**: Tech Design URL: CC: https://app.asana.com/0/1208613456171888/1208730499188670/f **Description**: <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> **Steps to test this PR**: 1. On first app startup - make sure that lookup rules succeeded and and fetch last compiled rules succeeded pixels are not being fired 2. On subsequent startup - make sure that lookup succeeded pixel is fired when there are not changes to the rules Refer to the TD linked above for more details <!-- Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you *know* do not need explicit testing. Using a simulator where a physical device is unavailable is acceptable. --> **OS Testing**: * [ ] iOS 14 * [ ] iOS 15 * [ ] iOS 16 * [ ] macOS 10.15 * [ ] macOS 11 * [ ] macOS 12 --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) --------- Co-authored-by: Bartek Waresiak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1208613456171888/1208801514911204/f
Tech Design URL: https://app.asana.com/0/1208613456171888/1208730499188670/f
CC:
Description:
Optional E2E tests:
Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.
Steps to test this PR:
1.
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation