Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger the Cookie Hidden animation early for filterlist rules #3584

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

muodov
Copy link
Member

@muodov muodov commented Nov 21, 2024

Task/Issue URL: https://app.asana.com/0/72649045549333/1208825971888846/f
Tech Design URL: https://app.asana.com/0/1201844467387842/1208738659527990/f
CC:

Description:

  • Make sure to show the CPM animation when cosmetic filterlist rules match.
  • This means that you will see "Cookie Hidden" animation if filterlist cosmetic rule hides something, but might see another one if an active rule matches later.
  • This is dependent on CPM changes, so when testing, please use this branch: max/autoconsent-filterlist-animation-review, or the test build in the Ship Review.

Optional E2E tests:

  • Run PIR E2E tests
    Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.

Steps to test this PR:
See the steps in Ship review: https://app.asana.com/0/72649045549333/1208825971888846/f

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@muodov muodov marked this pull request as ready for review November 22, 2024 14:40
@muodov muodov requested review from a team, tomasstrba, quanganhdo and mallexxx and removed request for a team, tomasstrba and quanganhdo November 22, 2024 15:16
@mallexxx mallexxx self-assigned this Nov 26, 2024
Copy link
Collaborator

@mallexxx mallexxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated the sites specified in the Asana task are displaying the popup hidden notification;
Please fix the minor thingies I mentioned inline and we‘re good to go 👍

DuckDuckGo/Autoconsent/AutoconsentUserScript.swift Outdated Show resolved Hide resolved
DuckDuckGo/Autoconsent/AutoconsentUserScript.swift Outdated Show resolved Hide resolved
DuckDuckGo/Autoconsent/AutoconsentUserScript.swift Outdated Show resolved Hide resolved
DuckDuckGo/Autoconsent/AutoconsentUserScript.swift Outdated Show resolved Hide resolved
@muodov muodov requested a review from mallexxx November 26, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants