Skip to content
Danger JS

Malware protection 5: Refactor Special Error Types #13369

Sign in to view logs

Malware protection 5: Refactor Special Error Types

Malware protection 5: Refactor Special Error Types #13369

Triggered via pull request November 27, 2024 11:57
@mallexxxmallexxx
opened #3603
alex/malware-protection-5
Status Success
Total duration 1m 35s
Artifacts –

danger.yml

on: pull_request
Danger JS
1m 25s
Danger JS
Fit to window
Zoom out
Zoom in

Annotations

8 errors
AppPrivacyConfigurationTests.testWhenEmbeddedDataIsUpdatedThenUpdateSHAAndEtag: DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests.build/Objects-normal/arm64/AppPrivacyConfigurationTests.d#L1
/Users/runner/work/macos-browser/macos-browser/UnitTests/ContentBlocker/AppPrivacyConfigurationTests.swift:42 - XCTAssertEqual failed: ("28ee4907c094516063039d4a927e51b8219a1761e66f021ed99f6e2b44533dbd") is not equal to ("19e8f4d1a27d51df8c2e153f868c62845f43a876db09176c0bc809e1fbfff1fd") - Error: please update SHA and ETag when changing embedded config
DuckSchemeHandlerTests.testErrorPageSchemeHandlerSetsError_WhenTokenInvalid: DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests.build/Objects-normal/arm64/DuckSchemeHandlerTests.d#L1
/Users/runner/work/macos-browser/macos-browser/UnitTests/DuckSchemeHandler/DuckSchemeHandlerTests.swift:165 - XCTAssertEqual failed: ("Error Domain=NSURLErrorDomain Code=-1000 "(null)" UserInfo={NSErrorFailingURLKey=duck://error?reason=phishing&url=aHR0cHM6Ly9wcml2YWN5LXRlc3QtcGFnZXMuc2l0ZS9zZWN1cml0eS9iYWR3YXJlL3BoaXNoaW5nLmh0bWw&token=ababababababababababab}") is not equal to ("Error Domain=Unexpected Error Code=1 "Unexpected Error" UserInfo={NSLocalizedDescription=Unexpected Error, NSErrorFailingURLKey=about:blank}")
MaliciousSiteProtectionTests.testDidNotLoadAndStartDataActivities_IfFeatureDisabled: DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests.build/Objects-normal/arm64/MaliciousSiteProtectionTests.d#L1
/Users/runner/work/macos-browser/macos-browser/UnitTests/MaliciousSiteProtection/MaliciousSiteProtectionTests.swift:61 - XCTAssertFalse failed
OnboardingTabExtensionTests.test_WhenNavigatingToOnboardingURL_thenNavigationPolicyIsAllow: DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests.build/Objects-normal/arm64/OnboardingTabExtensionTests.d#L1
/Users/runner/work/macos-browser/macos-browser/UnitTests/Onboarding/OnboardingTabExtensionTests.swift:49 - XCTAssertTrue failed - nil
AppPrivacyConfigurationTests.testWhenEmbeddedDataIsUpdatedThenUpdateSHAAndEtag: DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests App Store.build/Objects-normal/arm64/AppPrivacyConfigurationTests.d#L1
/Users/runner/work/macos-browser/macos-browser/UnitTests/ContentBlocker/AppPrivacyConfigurationTests.swift:42 - XCTAssertEqual failed: ("28ee4907c094516063039d4a927e51b8219a1761e66f021ed99f6e2b44533dbd") is not equal to ("19e8f4d1a27d51df8c2e153f868c62845f43a876db09176c0bc809e1fbfff1fd") - Error: please update SHA and ETag when changing embedded config
DuckSchemeHandlerTests.testErrorPageSchemeHandlerSetsError_WhenTokenInvalid: DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests App Store.build/Objects-normal/arm64/DuckSchemeHandlerTests.d#L1
/Users/runner/work/macos-browser/macos-browser/UnitTests/DuckSchemeHandler/DuckSchemeHandlerTests.swift:165 - XCTAssertEqual failed: ("Error Domain=NSURLErrorDomain Code=-1000 "(null)" UserInfo={NSErrorFailingURLKey=duck://error?reason=phishing&url=aHR0cHM6Ly9wcml2YWN5LXRlc3QtcGFnZXMuc2l0ZS9zZWN1cml0eS9iYWR3YXJlL3BoaXNoaW5nLmh0bWw&token=ababababababababababab}") is not equal to ("Error Domain=Unexpected Error Code=1 "Unexpected Error" UserInfo={NSErrorFailingURLKey=about:blank, NSLocalizedDescription=Unexpected Error}")
MaliciousSiteProtectionTests.testDidNotLoadAndStartDataActivities_IfFeatureDisabled: DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests App Store.build/Objects-normal/arm64/MaliciousSiteProtectionTests.d#L1
/Users/runner/work/macos-browser/macos-browser/UnitTests/MaliciousSiteProtection/MaliciousSiteProtectionTests.swift:61 - XCTAssertFalse failed
OnboardingTabExtensionTests.test_WhenNavigatingToOnboardingURL_thenNavigationPolicyIsAllow: DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests App Store.build/Objects-normal/arm64/OnboardingTabExtensionTests.d#L1
/Users/runner/work/macos-browser/macos-browser/UnitTests/Onboarding/OnboardingTabExtensionTests.swift:49 - XCTAssertTrue failed - nil