Skip to content

Conversation

@landomen
Copy link
Contributor

@landomen landomen commented Dec 22, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1212150118866240?focus=true

Description

When the user changes their profile, the dashboard still shows In Progress records belonging to the old profile. These records will remain stuck as we no longer opt out for them.

The already removed records should still be visible.

Steps to test this PR

  • Run a full scan with a user profile until the dashboard shows In Progress records and the scan is finished
  • Update the user profile by changing a name or address
  • The initial scan should pick up again, the dashboard should not show In Progress records for the old profile
  • After the scan is finished the dashboard should show In Progress records only for the new profile.
  • Completed tab can still show records removed for the old profile if any

UI changes

No UI changes


Note

Filters out extracted profiles linked to deprecated profile queries from initial/maintenance in-progress results while still including them in removed opt-outs; updates plumbing and tests.

  • Backend
    • Filtering logic: PirDashboardStateProvider.getAllExtractedProfileResults(includeResultsForDeprecatedProfileQueries) now filters by non-deprecated ProfileQuery IDs from pirRepository.getValidUserProfileQueries().
    • Initial scan: RealPirDashboardInitialScanStateProvider.getScanResults calls the new API with includeResultsForDeprecatedProfileQueries = false.
    • Maintenance scan:
      • getInProgressOptOuts excludes deprecated-profile-query results.
      • getRemovedOptOuts includes deprecated-profile-query results (passes true).
  • Tests
    • Extend test helpers to set profileQueryId and create ProfileQuery objects.
    • Add/adjust unit tests to verify filtering for in-progress vs. removed results and mirror-site behavior.

Written by Cursor Bugbot for commit 07692b3. This will update automatically on new commits. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants