Rework DaxText Composable contract #7411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

GerardPaligot wants to merge 1 commit into develop from feature/gerard/rework-daxtext

+129 −155

Contributor

GerardPaligot commented Dec 19, 2025 •

edited

Loading

Task/Issue URL: https://app.asana.com/1/137249556945/project/1202857801505092/task/1212532766386636?focus=true

Description

Propose a new contract for the DaxText component that:

Supports usage of Compose locals (e.g., colors and typography inherited from parent components).
Is correctly wired into the theme to preserve and enforce DuckDuckGo theming rules.

Steps to test this PR

Open the application
Go to the settings
Scroll to "Android Design System Preview" and tap
Go to "Typography" tab
Check there is no difference between XML and Compose


          Rework DaxText Composable contract

507ae52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

malmstein Awaiting requested review from malmstein malmstein will be requested when the pull request is marked ready for review malmstein is a code owner

mikescamell Awaiting requested review from mikescamell mikescamell will be requested when the pull request is marked ready for review mikescamell is a code owner

At least 1 approving review is required to merge this pull request.

Labels

None yet