-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update release_create_tag flow using LGC #7395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Update release_create_tag flow using LGC #7395
Conversation
53b6d11 to
f88dbd8
Compare
| - name: Get LGC | ||
| id: get_lgc_tag | ||
| run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:2:27: Double quote to prevent globbing and word splitting [shellcheck]
| - name: Check for production release on LGC commit | ||
| id: check_production_release | ||
| run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:3:32: Double quote to prevent globbing and word splitting [shellcheck]
f88dbd8 to
90d2ccd
Compare
| id: get_lgc_tag | ||
| run: | | ||
| output=$(git tag -l "LGC-*" --sort=-refname | head -n 1) | ||
| echo "lgc_tag=$output" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Missing validation when no LGC tag exists
If no LGC tags exist in the repository, output from git tag -l "LGC-*" will be empty, and lgc_tag will be set to an empty string. The subsequent step on line 54 then runs git rev-list -n 1 with an empty argument, causing a cryptic git error. The workflow lacks validation to check if an LGC tag was actually found before proceeding, which would result in confusing error messages rather than a clear indication that no LGC tag exists.
Please tell me if this was useful or not with a 👍 or 👎.
Additional Locations (1)
| with: | ||
| ref: ${{ steps.get_lgc_tag.outputs.lgc_tag }} | ||
| submodules: recursive | ||
| fetch-depth: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: LGC tag checkout is immediately overridden by fastlane
The new "Checkout LGC tag" step checks out the LGC tag, but the tag_and_push_release_version fastlane lane immediately runs git checkout main and then git checkout develop, completely overriding this checkout. The release branch is then created from develop, not from the LGC commit. This makes the LGC tag checkout ineffective and the release will not be created from the intended LGC commit, defeating the purpose of the "using LGC" flow described in the PR title.
Please tell me if this was useful or not with a 👍 or 👎.
| with: | ||
| ref: ${{ steps.get_lgc_tag.outputs.lgc_tag }} | ||
| submodules: recursive | ||
| fetch-depth: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Missing token in second checkout may break submodule fetch
The new checkout step at line 67 is missing the token: ${{ secrets.GT_DAXMOBILE }} parameter that the initial checkout at line 27 includes. While the remote URL was configured with the token at line 41, the actions/checkout action uses the token for fetching submodules recursively. If any submodules require authenticated access, this checkout could fail with the default github.token.
Please tell me if this was useful or not with a 👍 or 👎.

Task/Issue URL: https://app.asana.com/1/137249556945/task/1212502548756448?focus=true
Description
Steps to test this PR
Feature 1
LGC-2025-12-18T160726b3d875437e7c584fa3fb2be82dbe71ceb9f67bbcLGC-2025-12-18T160726/opt/homebrew/bin/git checkout --progress --force refs/tags/LGC-2025-12-18T160726LGC-2025-12-10T160726f55ba89ed435b5f1c5d9fe62ad6f61dc9017b161- 5.260.3
- LGC-2025-12-10T160726
Note
Workflow now tags releases from the latest
LGC-*tag’s commit, aborting if a semver production tag already exists on that commit..github/workflows/release_create_tag.yml):LGC-*tag and resolve its commit (get_lgc_tag).X.Y.Z); fail if found.LGC-*tag before running Fastlane to create/push the release tag.Written by Cursor Bugbot for commit 90d2ccd. This will update automatically on new commits. Configure here.