Skip to content

Conversation

@CrisBarreiro
Copy link
Contributor

@CrisBarreiro CrisBarreiro commented Dec 18, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/task/1212502548756448?focus=true

Description

Steps to test this PR

Feature 1

  • Check job is executed successfully with no release tags found
    • Getting commit for LGC tag: LGC-2025-12-18T160726
    • LGC commit: b3d875437e7c584fa3fb2be82dbe71ceb9f67bbc
    • All tags on LGC commit: LGC-2025-12-18T160726
    • Production release tag found: 'none'
    • Checking out the ref /opt/homebrew/bin/git checkout --progress --force refs/tags/LGC-2025-12-18T160726
  • Check job is executed and fails with release tags found
    • Getting commit for LGC tag: LGC-2025-12-10T160726
    • LGC commit: f55ba89ed435b5f1c5d9fe62ad6f61dc9017b161
    • All tags on LGC commit:
      - 5.260.3
      - LGC-2025-12-10T160726
    • Production release tag found: '5.260.3'
    • Error: LGC commit already has production release: 5.260.3
    • Error: Process completed with exit code 1.

Note

Workflow now tags releases from the latest LGC-* tag’s commit, aborting if a semver production tag already exists on that commit.

  • CI Workflow (.github/workflows/release_create_tag.yml):
    • Fetch latest LGC-* tag and resolve its commit (get_lgc_tag).
    • Verify the LGC commit has no existing production tag (semver X.Y.Z); fail if found.
    • Checkout the resolved LGC-* tag before running Fastlane to create/push the release tag.
    • Keep existing notifications and failure handling unchanged.

Written by Cursor Bugbot for commit 90d2ccd. This will update automatically on new commits. Configure here.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@CrisBarreiro CrisBarreiro force-pushed the feature/cris/lgc/use-lgc-in-release-tag-task branch from 53b6d11 to f88dbd8 Compare December 18, 2025 17:18
- name: Get LGC
id: get_lgc_tag
run: |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:2:27: Double quote to prevent globbing and word splitting [shellcheck]

- name: Check for production release on LGC commit
id: check_production_release
run: |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:3:32: Double quote to prevent globbing and word splitting [shellcheck]

@CrisBarreiro CrisBarreiro force-pushed the feature/cris/lgc/use-lgc-in-release-tag-task branch from f88dbd8 to 90d2ccd Compare December 19, 2025 11:22
@CrisBarreiro CrisBarreiro marked this pull request as ready for review December 19, 2025 11:37
id: get_lgc_tag
run: |
output=$(git tag -l "LGC-*" --sort=-refname | head -n 1)
echo "lgc_tag=$output" >> $GITHUB_OUTPUT
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing validation when no LGC tag exists

If no LGC tags exist in the repository, output from git tag -l "LGC-*" will be empty, and lgc_tag will be set to an empty string. The subsequent step on line 54 then runs git rev-list -n 1 with an empty argument, causing a cryptic git error. The workflow lacks validation to check if an LGC tag was actually found before proceeding, which would result in confusing error messages rather than a clear indication that no LGC tag exists.


Please tell me if this was useful or not with a 👍 or 👎.

Additional Locations (1)

Fix in Cursor Fix in Web

with:
ref: ${{ steps.get_lgc_tag.outputs.lgc_tag }}
submodules: recursive
fetch-depth: 0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: LGC tag checkout is immediately overridden by fastlane

The new "Checkout LGC tag" step checks out the LGC tag, but the tag_and_push_release_version fastlane lane immediately runs git checkout main and then git checkout develop, completely overriding this checkout. The release branch is then created from develop, not from the LGC commit. This makes the LGC tag checkout ineffective and the release will not be created from the intended LGC commit, defeating the purpose of the "using LGC" flow described in the PR title.


Please tell me if this was useful or not with a 👍 or 👎.

Fix in Cursor Fix in Web

with:
ref: ${{ steps.get_lgc_tag.outputs.lgc_tag }}
submodules: recursive
fetch-depth: 0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing token in second checkout may break submodule fetch

The new checkout step at line 67 is missing the token: ${{ secrets.GT_DAXMOBILE }} parameter that the initial checkout at line 27 includes. While the remote URL was configured with the token at line 41, the actions/checkout action uses the token for fetching submodules recursively. If any submodules require authenticated access, this checkout could fail with the default github.token.


Please tell me if this was useful or not with a 👍 or 👎.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants