Skip to content

Improve intent:// handling when the user clicks on an intent link #7382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
catalinradoiu wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Improve intent:// handling when the user clicks on an intent link #7382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1f5da8
Fix crash in custom tab when trying to open url in ddg app and no act…
catalinradoiu Dec 17, 2025
7ed1650
Check if intent package is null before returning the unknown type for…
catalinradoiu Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1465,7 +1465,12 @@ class BrowserTabFragment :
Intent(Intent.ACTION_VIEW).apply {
data = Uri.parse(url)
}
startActivity(intent)

if (requireActivity().packageManager.resolveActivity(intent, 0) != null) {
startActivity(intent)
} else {
showToast(R.string.unableToOpenLink)
}
}

private fun launchPopupMenu(
Expand Down
10 changes: 8 additions & 2 deletions app/src/main/java/com/duckduckgo/app/browser/SpecialUrlDetector.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ class SpecialUrlDetectorImpl(
): UrlType {
val uriString = uri.toString()

logcat(tag = "RadoiuC") { "Uri: $uri scheme: ${uri.scheme}" }
return when (val scheme = uri.scheme) {
TEL_SCHEME -> buildTelephone(uriString)
TELPROMPT_SCHEME -> buildTelephonePrompt(uriString)
Expand Down Expand Up @@ -91,7 +92,9 @@ class SpecialUrlDetectorImpl(
}
// if there's no redirects (initiatingUrl = null) then it's user initiated
val userInitiated = initiatingUrl == null
checkForIntent(scheme, uriString, intentFlags, userInitiated)
checkForIntent(scheme, uriString, intentFlags, userInitiated).also {
logcat(tag = "RadoiuC") { "Check for intent result: $it" }
}
}
}
}
Expand Down Expand Up @@ -206,7 +209,7 @@ class SpecialUrlDetectorImpl(
return try {
val intent = Intent.parseUri(uriString, intentFlags)
// only proceed if something can handle it
if (userInitiated && (intent == null || packageManager.resolveActivity(intent, 0) == null) &&
if (userInitiated && invalidIntentWithNoPackage(intent) &&
androidBrowserConfigFeature.validateIntentResolution().isEnabled()
) {
return UrlType.Unknown(uriString)
Expand Down Expand Up @@ -234,6 +237,9 @@ class SpecialUrlDetectorImpl(
return UrlType.SearchQuery(uriString)
}

private fun invalidIntentWithNoPackage(intent: Intent?) = intent == null ||
(packageManager.resolveActivity(intent, 0) == null && intent.`package` == null)

private fun buildFallbackIntent(fallbackUrl: String?): Intent? {
if (determineType(fallbackUrl) is UrlType.NonHttpAppLink) {
return Intent.parseUri(fallbackUrl, URI_ANDROID_APP_SCHEME)
Expand Down
Loading