Update sync APIs to support deletions #7340
Merged
+59
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
CDRussell
force-pushed
the
feature/craig/api_changes_for_syncing_duck_chat_deletions
branch
3 times, most recently
from
54b8050 to
06dea1c
Compare
18 tasks
CDRussell
force-pushed
the
feature/craig/api_changes_for_syncing_duck_chat_deletions
branch
from
06dea1c to
1dfedc6
Compare
CDRussell
force-pushed
the
feature/craig/api_changes_for_syncing_duck_chat_deletions
branch
from
1dfedc6 to
90905ef
Compare
CrisBarreiro
approved these changes
Dec 17, 2025
CDRussell
force-pushed
the
feature/craig/api_changes_for_syncing_duck_chat_deletions
branch
from
90905ef to
ab4b982
Compare
CDRussell
deleted the
feature/craig/api_changes_for_syncing_duck_chat_deletions
branch
cursor bot
pushed a commit
that referenced
this pull request
Dec 19, 2025
Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1212393987995393?focus=true ### Description Updates Sync APIs to support _deletions_. This PR adds data classes and callbacks to support deletions, but otherwise doesn't make any functional changes. ### Steps to test this PR - qa optional - Check changes against [API change: New sync engine interfaces for handling deletions](https://app.asana.com/1/137249556945/task/1212392279082571) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Introduce deletion support to the sync API via new models and a manager interface with success/error callbacks. > > - **Sync API**: > - **New Interface**: `DeletableDataManager` with `getDeletions()`, `getType()`, and callbacks `onSuccess(SyncDeletionResponse)` / `onError(SyncErrorResponse)`. > - **New Models**: `SyncDeletionRequest` and `SyncDeletionResponse` (optional `untilTimestamp`) for deletion operations. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit ab4b982. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1212393987995393?focus=true
Description
Updates Sync APIs to support deletions.
This PR adds data classes and callbacks to support deletions, but otherwise doesn't make any functional changes.
Steps to test this PR
Note
Introduce deletion support to the sync API via new models and a manager interface with success/error callbacks.
DeletableDataManagerwithgetDeletions(),getType(), and callbacksonSuccess(SyncDeletionResponse)/onError(SyncErrorResponse).SyncDeletionRequestandSyncDeletionResponse(optionaluntilTimestamp) for deletion operations.Written by Cursor Bugbot for commit ab4b982. This will update automatically on new commits. Configure here.