-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Traffic Quality Feature Flag #5328
Merged
malmstein
merged 12 commits into
develop
from
feature/david/11-26-traffic_quality_feature_flag
Dec 2, 2024
Merged
Traffic Quality Feature Flag #5328
malmstein
merged 12 commits into
develop
from
feature/david/11-26-traffic_quality_feature_flag
Dec 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malmstein
force-pushed
the
feature/david/11-26-traffic_quality_feature_flag
branch
from
November 28, 2024 10:03
ed4ef2f
to
a0ecf72
Compare
.../main/java/com/duckduckgo/app/browser/trafficquality/remote/AndroidFeaturesHeaderProvider.kt
Outdated
Show resolved
Hide resolved
joshliebe
reviewed
Nov 28, 2024
app/src/main/java/com/duckduckgo/app/buildconfig/RealAppBuildConfig.kt
Outdated
Show resolved
Hide resolved
joshliebe
reviewed
Nov 28, 2024
app/src/main/java/com/duckduckgo/app/browser/trafficquality/AndroidFeaturesHeader.kt
Outdated
Show resolved
Hide resolved
joshliebe
reviewed
Nov 28, 2024
.../main/java/com/duckduckgo/app/browser/trafficquality/remote/AndroidFeaturesHeaderProvider.kt
Show resolved
Hide resolved
joshliebe
reviewed
Nov 28, 2024
.../main/java/com/duckduckgo/app/browser/trafficquality/remote/AndroidFeaturesHeaderProvider.kt
Outdated
Show resolved
Hide resolved
joshliebe
reviewed
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works as expected. I left a few comments, when they have been resolved, I will re-test.
joshliebe
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks @joshliebe ! |
malmstein
deleted the
feature/david/11-26-traffic_quality_feature_flag
branch
December 2, 2024 10:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1174433894299346/1208848089144698/f
Description
Implement the header request that sends one enabled feature
Steps to test this PR
See Test scenarios section in the description of the Asana task -> https://app.asana.com/0/1174433894299346/1208865134645715/f