Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traffic Quality Feature Flag #5328

Merged
merged 12 commits into from
Dec 2, 2024

Conversation

malmstein
Copy link
Contributor

@malmstein malmstein commented Nov 27, 2024

Task/Issue URL: https://app.asana.com/0/1174433894299346/1208848089144698/f

Description

Implement the header request that sends one enabled feature

Steps to test this PR

See Test scenarios section in the description of the Asana task -> https://app.asana.com/0/1174433894299346/1208865134645715/f

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@malmstein malmstein force-pushed the feature/david/11-26-traffic_quality_feature_flag branch from ed4ef2f to a0ecf72 Compare November 28, 2024 10:03
@malmstein malmstein marked this pull request as ready for review November 28, 2024 22:03
@joshliebe joshliebe self-assigned this Nov 28, 2024
Copy link
Contributor

@joshliebe joshliebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected. I left a few comments, when they have been resolved, I will re-test.

Copy link
Contributor

@joshliebe joshliebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@malmstein
Copy link
Contributor Author

Thanks @joshliebe !

@malmstein malmstein merged commit facdf85 into develop Dec 2, 2024
7 checks passed
@malmstein malmstein deleted the feature/david/11-26-traffic_quality_feature_flag branch December 2, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants