Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update subscription activation screens #5325

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

LukasPaczos
Copy link
Contributor

@LukasPaczos LukasPaczos commented Nov 27, 2024

Task/Issue URL: https://app.asana.com/0/1208671518894266/1208848139000087

Description

Updates the subscription activation screens according to designs, details in the task (and sub-tasks).

Steps to test this PR

Subscription activation screen

  • Without subscription active, open subscription activation screen.
    • If you are in the US, open "I Have a Subscription".
    • If you're not in the US, go to Settings -> Subscription Settings -> Already have a subscription, or follow guidelines from https://app.asana.com/0/1207137509162935/1208816938325110/f.
    • Make sure design matches in light and dark modes.
    • Make sure adding via email opens the FE activation flow.

Subscription settings screen

  • With subscription active, open subscription settings screen.
    • Make sure that clicking Add to Device opens the FE activation flow.

UI changes

Subscription activation screen

Before After
Screenshot_20241127_143447 Screenshot_20241127_143633
Screenshot_20241127_143457 Screenshot_20241127_143643

Subscription settings screen (I haven't re-taken screenshots for dark mode)

Before After
Screenshot_20241127_144505 Screenshot_20241127_144625
Screenshot_20241127_144542 Screenshot_20241127_144750

@LukasPaczos LukasPaczos force-pushed the feature/lukasz-p/update-subscription-activation branch 3 times, most recently from b28bf36 to c46adce Compare November 28, 2024 14:34
@LukasPaczos LukasPaczos marked this pull request as ready for review November 28, 2024 14:37
@LukasPaczos LukasPaczos force-pushed the feature/lukasz-p/update-subscription-activation branch from c46adce to b1edb04 Compare November 28, 2024 14:46
@lmac012 lmac012 self-assigned this Nov 28, 2024
@LukasPaczos LukasPaczos force-pushed the feature/lukasz-p/update-subscription-activation branch from b1edb04 to 263c931 Compare December 2, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants