Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log RC download error types #5320

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Log RC download error types #5320

merged 1 commit into from
Nov 27, 2024

Conversation

aitorvs
Copy link
Collaborator

@aitorvs aitorvs commented Nov 26, 2024

Task/Issue URL: https://app.asana.com/0/488551667048375/1208034017399945/f

Description

Log the different error types when DL(ding) the remote config

Steps to test this PR

Test

  • install from this branch
  • force the different errors in DownloadError. Some of them modifying code others using eg. jsonblob as remote config
  • verify the corresponding pixels are sent

Copy link
Collaborator Author

aitorvs commented Nov 26, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@aitorvs aitorvs merged commit d522487 into develop Nov 27, 2024
8 checks passed
@aitorvs aitorvs deleted the feature/aitor/rc/errors branch November 27, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants