Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simplified ("toggle") broken site reporting #5280

Merged
merged 52 commits into from
Dec 6, 2024
Merged

Add simplified ("toggle") broken site reporting #5280

merged 52 commits into from
Dec 6, 2024

Conversation

laghee
Copy link
Collaborator

@laghee laghee commented Nov 15, 2024 •
edited by lmac012
Loading

Task/Issue URL: https://app.asana.com/0/1201870266890790/1208769785329643/f

Description

We're implementing the simplified broken site reporting flow that already exists on other platforms here, prompting users to report site breakage on URLs where they toggle off protections.

Steps to test this PR

Toggle Reports

  • Set up your local environment by checking out the privacy-dashboard branch and editing app/build.gradle to point to its location (replacing this bit).
  • Navigate to any non-DuckDuckGo site and tap the privacy shield, then toggle off protections
    • Confirm that you're shown the report prompting screen
    • Click on "See what's sent" and confirm the data details expand into view
    • Tap "Send report" and confirm that the m_protection-toggled-off-breakage-report pixel is sent with reportFlow=on_protections_off_dashboard_main
  • Re-enable protections
  • Tap the 3-dot menu and then "Disable privacy protection"
    • Confirm that you're again shown the prompt screen
    • Tap "Send report" and confirm that the above pixel is sent with reportFlow=on_protections_off_menu
  • Re-enable protections
  • Toggle off protections again from either entry point and confirm that you are again show the prompt
    • Tap "Don't send"
    • Confirm that you are no longer shown the prompt from either toggle-off point (block should last 48 hours, but that value can be overridden by the remote privacy config -- there is an existing JSONblob with both intervals set to 2 minutes if you'd like to test more exhaustively, as I did)

@laghee laghee requested a review from lmac012 November 15, 2024 15:52
lmac012
lmac012 approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@lmac012 lmac012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested after the bump to dashboard 7.3.0 and everything works as expected 👍

@laghee laghee merged commit c21801c into develop Dec 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aitorvs aitorvs aitorvs left review comments

@lmac012 lmac012 lmac012 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laghee @lmac012 @aitorvs