Update duckdb to v1.3.1 #625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the problem is that currently this links v1.3.1 of DuckDB. If I try to load the debug built of current v1.3.1 branch, it fails. This pull request updates the commit to v1.3.1 tag of duckdb repo.
Invalid Input Error:Failed to load 'build/debug/extension/spatial/spatial.duckdb_extension', The file was built specifically for DuckDB version 'v1.3.0' and can only be loaded with that version of DuckDB. (this version of DuckDB is 'v1.3.1')edit:
The CI setting is correctly referring to v1.3.1, so this might not matter on CI builds. But, anyway I think updating this is a good idea.
https://github.com/duckdb/duckdb-spatial/blob/v1.3.1/.github/workflows/MainDistributionPipeline.yml