Fix #328 - Dont do limit pushdown during parallel execution #330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#328
LIMIT pushdown was added to this extension. #313
It pushes LIMIT down to Postgres and removes it from the DuckDB query plan.
Problem is that parallelism can occur in the extension, and one Query gets turned into n postgres queries. Pushing LIMIT down then falsifies the result.
A test is added, using
set pg_pages_per_task=1
, that reproduces this by forcing parallelism.I added a check on
max_threads
, which makes it so that LIMIT is NOT pushed down, if it is anything other than1
.This should prevent LIMIT from being pushed down in any case where we would have parallel queries from the best of my knowledge. (There could be a better way to check for parallelism that I am not aware of)
Previously
AFTER (NO LIMIT DURING PARALLEL)