Add predicate pushdown #72
Conversation
|
@samansmink this PR adds predicate pushdown for Iceberg. It does not currently support CTEs. closes #2 although more work is needed to support multiple iceberg scans (e.g. thru a CTE). |
|
Hey @mike-luabase! Thanks for the PR! Please be aware that we are planning to migrate the Iceberg scan from the current bind_replace to use the MultiFileReader interface, see this PR. However, since i can't give an expected timeline for that at this moment, I think this can be a good intermediate solution to have predicate pushdown working in the meantime. Just be aware that the code might get replaced at some point. |
|
@mike-luabase I've updated the iceberg extension repo to 1.1.1. Merging with master should build your changes against latest stable duckdb and latest CI. Would you also mind adding a description describing how you tackled the (pretty complex!) task of supporting filter pushdown? This makes it easier for future maintainers to understand how this works. |
|
For anyone following along, this was moved to 👉 #78 |
I don't know, it looks like that pull request has stalled. The author hasn't responded to feedback which, is fair given how long it took to receive it. |
|
Yeah, thats fair. I was mostly making sure there was a link from #2 -> #72 -> #78 for anyone curious on predicate pushdown. I'm mostly just excited to see what @Mytherin and the DuckDB Labs team bring in the world of Iceberg and lakehouses this year. It was mentioned as a priority at Duckcon the other week! |
No description provided.