Support for Enums #1328
Open
Support for Enums #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
December 27, 2023 11:25
|
@dorezyuk what's the status on this ? |
|
I think its in a zombie state - I've reached out when I was working on it to @dtolnay to check how to add this into the repo (its a massive PR after all) and David said he has capacity right now to review (and maintain) such large features. But it does not mean that the people interested in this (especially the cpp/Rust gurus here) should not review it. Maybe this will even help to ease the burden from David edit typo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds
std::variantlike type with the same memory layout as Rust's enum and codegen code to generate binding to c++ from Rust.The PR is quite massive and I've know that there is currently little active development at this project. Nonetheless, if the development is ever picked up, it would be great to include the feature.
It should probably also go behind a feature flag..