Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty sparse matrices dont need np.zeros #295

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

empty sparse matrices dont need np.zeros #295

wants to merge 1 commit into from

Conversation

dswah
Copy link
Owner

@dswah dswah commented Apr 9, 2021

we dont need to us np.zeros(...) to initialize an empty sparse matrix (since this would also defeat the purpose)

@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #295 (1326b99) into master (b57b4cf) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #295      +/-   ##
==========================================
+ Coverage   95.21%   95.28%   +0.06%     
==========================================
  Files          22       22              
  Lines        3178     3222      +44     
==========================================
+ Hits         3026     3070      +44     
  Misses        152      152              
Impacted Files Coverage Δ
pygam/penalties.py 93.33% <100.00%> (ø)
pygam/terms.py 94.60% <100.00%> (+0.19%) ⬆️
pygam/tests/test_terms.py 100.00% <0.00%> (ø)
pygam/pygam.py 94.80% <0.00%> (+<0.01%) ⬆️
pygam/tests/test_utils.py 96.55% <0.00%> (+0.04%) ⬆️
pygam/callbacks.py 95.23% <0.00%> (+0.07%) ⬆️
pygam/distributions.py 88.88% <0.00%> (+0.48%) ⬆️
pygam/tests/conftest.py 98.21% <0.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b57b4cf...1326b99. Read the comment docs.

Copy link

@yahrMason yahrMason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants