Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for TXT & CNAME #61

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fixes for TXT & CNAME #61

wants to merge 2 commits into from

Conversation

hvisage
Copy link

@hvisage hvisage commented Oct 12, 2020

Okay, I mistakenly included the attempt to listen on several IPs (except those I don't want to listen on)

The Idea was to test for txt= and cname= and then (in order) if A type matched, do that, if AAAA matched, do that update, if CNAME matched, do that update, if TXT matched to that update, else try to find "myip"

@hvisage hvisage mentioned this pull request Oct 12, 2020
@develroo
Copy link

Checks failed. Was that a server glitch?


=== RUN   TestBuildWebserviceResponseFromRequestToReturnValidObject

--- FAIL: TestBuildWebserviceResponseFromRequestToReturnValidObject (0.00s)

panic: runtime error: invalid memory address or nil pointer dereference [recovered]

	panic: runtime error: invalid memory address or nil pointer dereference

[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x63264c]

@hvisage
Copy link
Author

hvisage commented Oct 24, 2020

My only answer: works still for me... either server glitch or testing I didn't know about to test or different environments/compilers ;(

cleaning up attempts
Golit added a commit to Golit/docker-ddns that referenced this pull request Mar 26, 2022
* Any record type can be updated by passing query parameter 'type' and
  'value' or 'addr' as a fallback
* Some code cleanup

Closes dstapp#49
Closes dstapp#61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants