Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project listing view: fix pagination and add creation date filter #55

Merged
merged 2 commits into from
Sep 3, 2020

Conversation

jesteria
Copy link
Member

@jesteria jesteria commented Sep 3, 2020

Resolves #36 and contributes to #54.

* cleaned up project list view

* refactored / cleaned up domain function to list / filter public projects
  and began domain namespace for projects

* fixed pagination of project listing page -- no longer discards filters

  as discusssed in #54, the platform's listing pages all suffer from
  submitting filters via POST, and previously from a pagination template
  which discarded any GET query params besides its own page number.

  the first problem was resolved in previous clean-up of the project
  listing view. this change fixes the pagination template, globally.

  the net result is that only the pagination of the project listing page
  is fixed, for now. (but the other pages may now be fixed by switching to
  GETs, alone.)
not super-useful as long as can't change sorting, and default is to
sort by posting date anyway; but, a start!

resolves #36
@jesteria jesteria added bug Something isn't working enhancement New feature or request ui User interface labels Sep 3, 2020
@jesteria jesteria self-assigned this Sep 3, 2020
@jesteria jesteria merged commit 57b63a3 into master Sep 3, 2020
@jesteria jesteria deleted the jsl/36-proj-date-filter branch September 3, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request ui User interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

project listing filter for date posted
1 participant