pagination of listing pages discards filter(s) #54
Labels
bug
Something isn't working
Comments
jesteria
added a commit
that referenced
this issue
Aug 27, 2020
as discusssed in #54, the platform's listing pages all suffer from submitting filters via POST, and previously from a pagination template which discarded any GET query params besides its own page number. the first problem was resolved in previous clean-up of the project listing view. this change fixes the pagination template, globally. the net result is that only the pagination of the project listing page is fixed, for now. (but the other pages may now be fixed by switching to GETs, alone.)
jesteria
added a commit
that referenced
this issue
Sep 3, 2020
* cleaned up project list view * refactored / cleaned up domain function to list / filter public projects and began domain namespace for projects * fixed pagination of project listing page -- no longer discards filters as discusssed in #54, the platform's listing pages all suffer from submitting filters via POST, and previously from a pagination template which discarded any GET query params besides its own page number. the first problem was resolved in previous clean-up of the project listing view. this change fixes the pagination template, globally. the net result is that only the pagination of the project listing page is fixed, for now. (but the other pages may now be fixed by switching to GETs, alone.)
jesteria
added a commit
that referenced
this issue
Sep 3, 2020
* cleaned up project list view * refactored / cleaned up domain function to list / filter public projects and began domain namespace for projects * fixed pagination of project listing page -- no longer discards filters as discusssed in #54, the platform's listing pages all suffer from submitting filters via POST, and previously from a pagination template which discarded any GET query params besides its own page number. the first problem was resolved in previous clean-up of the project listing view. this change fixes the pagination template, globally. the net result is that only the pagination of the project listing page is fixed, for now. (but the other pages may now be fixed by switching to GETs, alone.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The pagination of listing pages (projects, organizations, volunteers) discards any filter(s) set on the first page of results.
These filtering forms POST, rather than GET, unnecessarily – filter params aren't preserved for reuse. These may be safely stored in the GET query string.
The pagination template does not respect existing query params; these are discarded.
The issue with the project listing page is expected to be resolved within #36, as well as problem (2) above.
This will leave problem (1) to be resolved within the organization and volunteer listing pages.
The text was updated successfully, but these errors were encountered: