Merge pull request #1132 from PowerShell/release-3.7

Release 3.7
dsccommunity · Oct 30, 2019 · 872fd21 · 872fd21
2 parents 4a720ae + e3e5695
commit 872fd21
Show file tree

Hide file tree

Showing 36 changed files with 1,227 additions and 448 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,13 +1,48 @@
 # Change log for SharePointDsc
 
+## v3.7
+
+* SPConfigWizard
+  * Fixed issue with incorrect check for upgrade status of server
+* SPDistributedCacheService
+  * Improved error message for inclusion of server name into ServerProvisionOrder
+    parameters when Present or change to Ensure Absent
+* SPFarm
+  * Removed SingleServer as ServerRole, since this is an invalid role.
+  * Handle case where null or empty CentralAdministrationUrl is passed in
+  * Move CentralAdministrationPort validation into parameter definition
+    to work with ReverseDsc
+  * Add NotNullOrEmpty parameter validation to CentralAdministrationUrl
+  * Fixed error when changing developer dashboard display level.
+  * Add support for updating Central Admin Authentication Method
+* SPFarmSolution
+  * Fix for Web Application scoped solutions.
+* SPInstall
+  * Fixes a terminating error for sources in weird file shares
+  * Corrected issue with incorrectly detecting SharePoint after it
+    has been uninstalled
+  * Corrected issue with detecting a paused installation
+* SPInstallLanguagePack
+  * Fixes a terminating error for sources in weird file shares
+* SPInstallPrereqs
+  * Fixes a terminating error for sources in weird file shares
+* SPProductUpdate
+  * Fixes a terminating error for sources in weird file shares
+  * Corrected incorrect farm detection, added in earlier bugfix
+* SPSite
+  * Fixed issue with incorrectly updating site OwnerAlias and
+    SecondaryOwnerAlias
+* SPWebAppAuthentication
+  * Fixes issue where Test method return false on NON-US OS.
+
 ## v3.6
 
 * SharePointDsc generic
   * Added new launch actions to vscode to allow code coverage reports for
     the current unit test file.
 * SPFarm
   * Moved check for CentralAdministrationUrl is HTTP to Set method,
-    to prevent issues with ReverseDsc.
+    to prevent issues with ReverseDsc
 * SPInstall
   * Updated error code checks to force reboot.
 * SPProductUpdate

diff --git a/Modules/SharePointDsc/DSCResources/MSFT_SPConfigWizard/MSFT_SPConfigWizard.psm1 b/Modules/SharePointDsc/DSCResources/MSFT_SPConfigWizard/MSFT_SPConfigWizard.psm1
@@ -100,8 +100,9 @@ function Set-TargetResource
     Write-Verbose -Message "Checking if all servers in the farm have the binaries installed"
     $statusType = Get-SPDscServerPatchStatus
 
-    Write-Verbose -Message "Server status: $statusType (Has to be 'NoActionRequired' to continue)"
-    if ($statusType -ne "NoActionRequired")
+    Write-Verbose -Message ("Server status: $statusType (Has to be 'UpgradeAvailable' or " + `
+            "'UpgradeRequired' to continue)")
+    if ($statusType -ne "UpgradeRequired" -and $statusType -ne "UpgradeAvailable")
     {
         Write-Verbose -Message "Upgrade not possible, not all servers have the same binaries installed"
         return

diff --git a/...ePointDsc/DSCResources/MSFT_SPDistributedCacheService/MSFT_SPDistributedCacheService.psm1 b/...ePointDsc/DSCResources/MSFT_SPDistributedCacheService/MSFT_SPDistributedCacheService.psm1
@@ -238,7 +238,8 @@ function Set-TargetResource
                         if ($ServerCount -ge $params.ServerProvisionOrder.Length)
                         {
                             throw ("The server $($env:COMPUTERNAME) was not found in the " + `
-                                    "array for distributed cache servers")
+                                   "ServerProvisionOrder array of Distributed Cache server(s).  " + `
+                                   "The server must be included in ServerProvisionOrder or Ensure equal to Absent.")
                         }
                         $currentServer = $params.ServerProvisionOrder[$serverCount]
                     }

diff --git a/Modules/SharePointDsc/DSCResources/MSFT_SPDistributedCacheService/Readme.md b/Modules/SharePointDsc/DSCResources/MSFT_SPDistributedCacheService/Readme.md
@@ -22,6 +22,8 @@ By doing this you can ensure that you do not create conflicts with two or more
 servers provisioning a cache at the same time. Note, this approach only makes
 a server check the others for distributed cache, it does not provision the
 cache automatically on all servers. If a previous server in the sequence does
+not appear to be running distributed cache after 30 minutes, the local server
+that was waiting will begin anyway.
 
 The default value for the Ensure parameter is Present. When not specifying this
 parameter, the distributed cache is provisioned.
diff --git a/Modules/SharePointDsc/DSCResources/MSFT_SPExcelServiceApp/MSFT_SPExcelServiceApp.psm1 b/Modules/SharePointDsc/DSCResources/MSFT_SPExcelServiceApp/MSFT_SPExcelServiceApp.psm1
@@ -27,7 +27,6 @@ $Script:ServiceAppObjectType = "Microsoft.Office.Excel.Server.MossHost.ExcelServ
 function Get-TargetResource
 {
     [CmdletBinding()]
-    [Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSDSCUseIdenticalMandatoryParametersForDSC", "", Justification = "Temporary workaround for issue introduced in PSSA v1.18")]
     [OutputType([System.Collections.Hashtable])]
     param (
         [Parameter(Mandatory = $true)]
@@ -219,7 +218,6 @@ function Get-TargetResource
 function Set-TargetResource
 {
     [CmdletBinding()]
-    [Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSDSCUseIdenticalMandatoryParametersForDSC", "", Justification = "Temporary workaround for issue introduced in PSSA v1.18")]
     param
     (
         [Parameter(Mandatory = $true)]
@@ -475,7 +473,6 @@ function Set-TargetResource
 function Test-TargetResource
 {
     [CmdletBinding()]
-    [Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSDSCUseIdenticalMandatoryParametersForDSC", "", Justification = "Temporary workaround for issue introduced in PSSA v1.18")]
     [OutputType([System.Boolean])]
     param
     (