Fixed review comments

dsccommunity · Apr 7, 2021 · 7e2b9b8 · 7e2b9b8
1 parent 759aa49
commit 7e2b9b8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/SharePointDsc/DSCResources/MSFT_SPUsageDefinition/MSFT_SPUsageDefinition.psm1 b/SharePointDsc/DSCResources/MSFT_SPUsageDefinition/MSFT_SPUsageDefinition.psm1
@@ -49,7 +49,7 @@ function Get-TargetResource
         -ScriptBlock {
         $params = $args[0]
 
-        $usageDefinition = Get-SPUsageDefinition | Where-Object { $_.Name -eq $params.Name }
+        $usageDefinition = Get-SPUsageDefinition -Identity $params.Name
         $nullReturn = @{
             Name                 = $params.Name
             DaysRetained         = $params.DaysRetained
@@ -162,7 +162,7 @@ function Set-TargetResource
         $params = $args[0]
         $eventSource = $args[1]
 
-        $usageDefinition = Get-SPUsageDefinition | Where-Object { $_.Name -eq $params.Name }
+        $usageDefinition = Get-SPUsageDefinition -Identity $params.Name
 
         if ($null -eq $usageDefinition)
         {

diff --git a/tests/Unit/SharePointDsc/SharePointDsc.SPUsageDefinition.Tests.ps1 b/tests/Unit/SharePointDsc/SharePointDsc.SPUsageDefinition.Tests.ps1
@@ -102,6 +102,8 @@ try
                     {
                         $testParams.UsageDatabaseEnabled = $true
                     }
+
+                    Mock -CommandName Get-SPUsageDefinition -MockWith { return $null }
                 }
 
                 It "Should return false when the Test method is called" {
-Original file line number
+Diff line change
@@ Expand Up / @@ -102,6 +102,8 @@ try @@
                         {
                             $testParams.UsageDatabaseEnabled = $true
                         }
+                        Mock -CommandName Get-SPUsageDefinition -MockWith { return $null }
                     }
                     It "Should return false when the Test method is called" {
@@ Expand Down @@