[Suggestion] Fluid Selection #351
Open
+101
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the select and cancel buttons and made the buttons directly select the server
Edited the account selection menu so that it can be oppened in "popup" mode, allowing similar behavior to the fluid server selection without disturbing the account selection already in place in case of an account validation failure. This new popup menu also adds a "manage accounts" button to open the settings in the same way the old account selection menu did
|
I love the changes and love to see them added in the launcher. Thanks for making this ! |
|
I love this! however, there is some strange error when pressing "esc" key, it throws a lore ipsum and blocks the launcher lmao |
|
Hello! Thank you! I'll check that asap By the way, the Lorem Ipsum is the default text shown in the overlay component, you're supposed to set its text before showing it. However since this part of the overlay is not supposed to open, this text is never set. |
|
Yup I can confirm that this issue can indeed be encountered when closing the account selection menu with [esc], I will start working on fixing it now. |
…ng the overlay properly
|
Done! The esc key now work properly on both the server and the account selection! |
|
+1 - Def need this 👁️👁️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed some usability challenges within the current launcher interface, including numerous small buttons and unnecessary steps for common actions. In an effort to enhance user experience, I've proposed several optimizations.
In the linked video below, you can observe the adjustments I've made:
Current launcher experience:
2024-05-12.17-38-29.mp4
Launcher experience with the changes implemented in this pull request:
2024-05-12.17-39-43.mp4
Any feedback or suggestions for further refinement is welcomed.